Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEFECT] Design: Footer design in 1.8 has empty space added #399

Closed
AlexSkrypnyk opened this issue Oct 2, 2024 · 2 comments
Closed

[DEFECT] Design: Footer design in 1.8 has empty space added #399

AlexSkrypnyk opened this issue Oct 2, 2024 · 2 comments
Labels
Type: Defect Issue is a defect

Comments

@AlexSkrypnyk
Copy link
Contributor

CivicTheme__Design_System_v1_8_0_–_Figma

Can you please revert this change in the Figma or provide more information about why that change was introduced.
@AlexSkrypnyk AlexSkrypnyk changed the title Design: Footer design in 1.8 has empty space added [DEFECT] Design: Footer design in 1.8 has empty space added Oct 2, 2024
@fionamorrison23
Copy link
Collaborator

@AlexSkrypnyk I can see the design is like this back in 1.4. However, this is not the case in code. The footer is displaying as expected on the CivicTheme sites. I'll have @alanrako update the design. Thanks for raising.

@github-project-automation github-project-automation bot moved this to Todo in UI Kit Oct 30, 2024
@fionamorrison23 fionamorrison23 added the Type: Defect Issue is a defect label Oct 30, 2024
@alanrako alanrako removed their assignment Nov 8, 2024
@alanrako
Copy link

alanrako commented Nov 8, 2024

@fionamorrison23
Updated the desktop design so the footer displays 4 columns of equal width.
Please approve.
Device=Desktop, Dark Theme=False
Device=Desktop, Dark Theme=True

@github-project-automation github-project-automation bot moved this from Todo to Done in UI Kit Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Defect Issue is a defect
Projects
UI Kit
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlexSkrypnyk @fionamorrison23 @alanrako