[#378] Fixed error message with screen reader. #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febdao
added
the
PR: Needs review
| @@ -29,8 +29,9 @@ | |||
| name="{{ name }}" | |||
| value="{{ value }}" | |||
| id="{{ id }}" | |||
| {% if is_invalid and id %}aria-describedby="{{ id }}-message"{% endif %} | |||
There was a problem hiding this comment.
Does this work with Drupal?
There was a problem hiding this comment.
ie seems like we would need to pass the entire ID of the message block at the top of the screen
| @@ -7,6 +7,7 @@ exports[`Field Message Component allows HTML content 1`] = ` | |||
|
|
|||
| <div | |||
| class="ct-field-message ct-theme-light ct-field-message--information " | |||
| id="" | |||
There was a problem hiding this comment.
We should never have an empty id
| {% if is_disabled %}disabled{% endif %} | ||
| {% if is_required %}required{% endif %} | ||
| {% if is_required %}required aria-invalid="{{ is_invalid ? is_invalid : 'false' }}"{% endif %} |
There was a problem hiding this comment.
If it is not invalid why do we want to add this attribute?
There was a problem hiding this comment.
Think this should be outside of the is_required attribute check
| {% if is_multiple %}multiple{% endif %} | ||
| {% if is_disabled %}disabled{% endif %} | ||
| {% if is_required %}required{% endif %} | ||
| {% if is_required %}required aria-invalid="{{ is_invalid ? is_invalid : 'false' }}"{% endif %} |
richardgaunt
requested changes
Dec 16, 2024
There was a problem hiding this comment.
@febdao I have some questions about the use of aria-invalid and its position within the component
richardgaunt
added
PR: Requires more work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #378
Jira ticket:
Checklist before requesting a review
as
[#123] Verb in past tense with a period at the end.Changedsection about WHY something wasdone if this was a bespoke implementation.
and they have passed.
Changed
Screenshots