Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhdcScrubber mis-assigning suburb and road type #15

Open
ColinAnthony opened this issue Sep 30, 2020 · 0 comments
Open

PhdcScrubber mis-assigning suburb and road type #15

ColinAnthony opened this issue Sep 30, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@ColinAnthony
Copy link

I noticed an issue with the PhdcScrubber

  • PhdcScrubber does a lookup to find extra address info to improve the geocoding
  • road type (street, road, avenue, way etc.) appear to be ignored when doing the lookup, which can lead to incorrect assignment
    also
  • the output uses the input road type, regardless of the match

for the address Peak road Cape Town

There are 3 Peak Roads in the greater Cape Town area (Devils Peak, Fish Hoek and Pringle Bay) and a Peak Drive in Pinelands

The scrubber returns:

{
  "id": "4ef06662-2065-423c-bde1-cd65050b1087",
  "results": [
    {
      "confidence": 1,
      "scrubbed_value": "Peak road Cape Town, Western Cape, South Africa",
      "scrubber_id": "BasicScrubber"
    },
    {
      "confidence": 0.4,
      "scrubbed_value": "PEAK ROAD PINELANDS CAPE TOWN",
      "scrubber_id": "PhdcScrubber"
    }
  ],
  "timestamp": "2020-09-30T09:57:04.786381+02:00"
}

PhdcScrubber returned "PEAK ROAD PINELANDS CAPE TOWN, which is actually Peak Drive, Pinelands, Cape Town

@ColinAnthony ColinAnthony added the bug Something isn't working label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant