Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The domain objects have public modifier for its fields #153

Open
c5ms opened this issue Nov 24, 2024 · 1 comment
Open

The domain objects have public modifier for its fields #153

c5ms opened this issue Nov 24, 2024 · 1 comment

Comments

@c5ms
Copy link
Contributor

c5ms commented Nov 24, 2024

Currently the domain objects like Cargo have the public modifier for it's fields.

The domain object should not use public modifier for its field since the client(library user) will change the field, this will cause the domain object has an unstable status.
@c5ms c5ms mentioned this issue Nov 24, 2024
Merged
@c5ms
Copy link
Contributor Author

c5ms commented Nov 24, 2024

see PR:
#154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@c5ms