Fix console stats -x not working on mlx5 cards
#1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least in DPDK 23.03 (and later) xstats_names might return more names than xstats_values and that is considered normal. See https://doc.dpdk.org/api-23.03/rte__ethdev_8h.html#a300d75b583c1f5acfe5b162a5d8c0ac1 In this case it seems appropriate to force names to be same length as values Fixes cisco-system-traffic-generator#1111
|
Checked SHA: 40c38b4 |
|
@hhaim would it be possible for you to look at this PR? As to be honest, I don't want to maintain my own fork but without that patch TUI doesn't work properly on ConnectX-6 and 7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least in DPDK 23.03 (and later) xstats_names might return more names than xstats_values and that is considered normal.
See https://doc.dpdk.org/api-23.03/rte__ethdev_8h.html#a300d75b583c1f5acfe5b162a5d8c0ac1
In this case it seems appropriate to force names to be same length as values
Fixes #1111