Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-pre-commit Hook Does Not Check All docker-compose Files #66

Open
mcdonnnj opened this issue Jan 10, 2021 · 0 comments
Open

docker-pre-commit Hook Does Not Check All docker-compose Files #66

mcdonnnj opened this issue Jan 10, 2021 · 0 comments
Labels
bug This issue or pull request addresses broken functionality

Comments

@mcdonnnj
Copy link
Member

🐛 Summary

The IamTheFij/docker-pre-commit repo's docker-compose-check hook that we use only checks files ending in docker-compose.y[a]ml.This can be seen here:

https://github.com/IamTheFij/docker-pre-commit/blob/aeda358a4a1a064958fd994c9209047bd8c783c8/.pre-commit-hooks.yaml#L7

Expected behavior

Any docker-compose*.y[a]ml file is checked. There are a number of repos where we have multiple docker-compose configurations, and they are not being checked with this hook.
@mcdonnnj mcdonnnj added the bug This issue or pull request addresses broken functionality label Jan 10, 2021
@mcdonnnj mcdonnnj changed the title docker-pre-commit Hook Does not Check All docker-compose Files docker-pre-commit Hook Does Not Check All docker-compose Files Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcdonnnj