Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: added documentation for circe-derivation #1428

Closed

Conversation

shrynx
Copy link

@shrynx shrynx commented Mar 16, 2020

adds documentation for circe-derivation

closes circe/circe-derivation#188

@shrynx shrynx requested a review from travisbrown as a code owner March 16, 2020 16:22
@shrynx shrynx changed the title added documentation for circe-derivation WIP: added documentation for circe-derivation Mar 16, 2020
@travisbrown
Copy link
Member

Thanks! The content looks good to me. The CI failure is because we'll need to add circe-derivation to the docs build (since they're compiled). I can look at that this weekend, unless you want to take a shot at it sooner.

@shrynx
Copy link
Author

shrynx commented Mar 20, 2020

yes i am waiting for the new release of circe-derivation to link to as old will give errors
will update this once after release

@travisbrown
Copy link
Member

@shrynx Ah, got it, makes sense. I'll try to get around to publishing an M4 today.

@shrynx shrynx force-pushed the shrynx/add-docs-for-circe-derivation branch from f061466 to 9cf94ec Compare March 30, 2020 10:09
@shrynx
Copy link
Author

shrynx commented Mar 30, 2020

@travisbrown i added circe-derivation to deps but not sure why is one failing

@travisbrown
Copy link
Member

@shrynx It says the build was stalled, so probably just Travis CI being Travis CI. I restarted the job.

@shrynx
Copy link
Author

shrynx commented Mar 30, 2020

@travisbrown looks like it is getting stuck only on scala 2.12.10

@hamnis hamnis added the Close candidate Close candiate due to lack of interest by upstream label Apr 22, 2024
@hamnis
Copy link
Collaborator

hamnis commented May 28, 2024

Closed due to age.

Please notify maintainers if this is done in error.

@hamnis hamnis closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Close candidate Close candiate due to lack of interest by upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add documentation
3 participants