Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emoji ordering #2057

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Fix emoji ordering #2057

wants to merge 4 commits into from

Conversation

marekvospel
Copy link

@marekvospel marekvospel commented Nov 16, 2024

Description

When using emojis in cinny I noticed the order of emojis and stickers being the same as the order I uploaded them. Later when inviting my friends to the room, they showed me, that their order of emojis is different. (across homeservers)
image
image

This PR aims to fix this by ordering the emotes alphabetically (which feels like the most logical way to order them) both in emoji picker and inside autocomplete.

Related to #1632 (doesn't fix it, but makes the autocomplete behavior more predictable)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Nov 16, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@marekvospel
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Nov 16, 2024
@marekvospel marekvospel marked this pull request as ready for review November 16, 2024 12:03
Copy link

github-actions bot commented Nov 17, 2024

Preview: https://2057--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ajbura ajbura self-requested a review November 21, 2024 13:36
Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

I think it doesn't fix #1632 specifically as it sort the the search result alphabetically rather than how well they match with the query as per request.
For example searching fire result in list containing heart_on_fire , firefighter which should be sorted based on the index of fire, result word-size and does fire is on the word boundary.

@marekvospel
Copy link
Author

Overall LGTM.

I think it doesn't fix #1632 specifically as it sort the the search result alphabetically rather than how well they match with the query as per request.
For example searching fire result in list containing heart_on_fire , firefighter which should be sorted based on the index of fire, result word-size and does fire is on the word boundary.

True, I'll update the description to be more precise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants