-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix emoji ordering #2057
base: dev
Are you sure you want to change the base?
Fix emoji ordering #2057
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Preview: https://2057--pr-cinny.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
I think it doesn't fix #1632 specifically as it sort the the search result alphabetically rather than how well they match with the query as per request.
For example searching fire
result in list containing heart_on_fire , firefighter
which should be sorted based on the index of fire
, result word-size and does fire
is on the word boundary.
True, I'll update the description to be more precise. |
Description
When using emojis in cinny I noticed the order of emojis and stickers being the same as the order I uploaded them. Later when inviting my friends to the room, they showed me, that their order of emojis is different. (across homeservers)
This PR aims to fix this by ordering the emotes alphabetically (which feels like the most logical way to order them) both in emoji picker and inside autocomplete.
Related to #1632 (doesn't fix it, but makes the autocomplete behavior more predictable)
Type of change
Checklist: