Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix push notifications for rooms and direct messages not saving #2074

Closed
wants to merge 1 commit into from

Conversation

Mystically11
Copy link

Description

This PR aims to fix push notification setting changes not being pushed to the API and push notification settings not being visually updated when changed until window refresh.

Behavior before fix:
https://github.com/user-attachments/assets/af354aab-b755-473a-a28b-6b5fb63da9dc
image

Behavior after fix:
https://github.com/user-attachments/assets/9efc1821-75dc-4405-ab5c-cf8b75a83e82
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Dec 2, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Mystically11
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Dec 2, 2024
@Mystically11 Mystically11 marked this pull request as draft December 2, 2024 06:33
@Mystically11 Mystically11 deleted the test branch December 3, 2024 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant