Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add symbol function to String module #941

Closed
cieslarmichal opened this issue Oct 3, 2024 · 3 comments · Fixed by #946
Closed

add symbol function to String module #941

cieslarmichal opened this issue Oct 3, 2024 · 3 comments · Fixed by #946
Assignees
@tonykcao
Labels
good first issue Good for newcomers
Milestone
v4.0.0

Comments

@cieslarmichal
Copy link
Owner

like https://fakerjs.dev/api/string.html#symbol
@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Oct 3, 2024
@cieslarmichal cieslarmichal added this to the v4.0.0 milestone Oct 3, 2024
@tonykcao
Copy link
Contributor

tonykcao commented Oct 4, 2024

Hi I would like to take this issue! @cieslarmichal

@cieslarmichal
Copy link
Owner Author

Hello, assigned :) consider giving a star to the repository to make this project more popular 😎

tonykcao added a commit to tonykcao/faker-cxx that referenced this issue Oct 4, 2024
@tonykcao
feat: add symbol function cieslarmichal#941
8b5e167
@tonykcao
Copy link
Contributor

tonykcao commented Oct 4, 2024

PR made #946, awating automated checks

@cieslarmichal cieslarmichal linked a pull request Oct 4, 2024 that will close this issue
feat: add symbol function #941 #946
Merged
cieslarmichal pushed a commit that referenced this issue Oct 4, 2024
@tonykcao
feat: add symbol function #941 (#946)
c33908d 
Co-authored-by: Tony Cao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonykcao tonykcao

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

feat: add symbol function #941 tonykcao/faker-cxx
2 participants
@cieslarmichal @tonykcao