-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Locale enum #752
Comments
Hi @cieslarmichal I want to work on this issue, can you please provide more context ? |
hello, so instead of types that are specific for language, location we would like to combine them to have standardized enum param for all methods so user can just choose use with this issue just create a new enum, dont modify existing ones |
|
If no one is working on this I can take it up. |
Ok. Assigned |
To be clear, do you want to end up with an enum that is the number of languages multiplied by the number of countries large? This would lead to severe code bloat and would not be easily maintainable. Why not combine
|
Locale defines both country and language at once, it won't have
Here is a reference for locales in Oracle docs: https://docs.oracle.com/cd/E23824_01/html/E26033/glset.html Hope it will make sense now. Also locales in faker.js: https://github.com/faker-js/faker/tree/next/src/locales |
further work to be done: #825 |
Got it, in the interest of time how about we just scrape https://docs.oracle.com/cd/E23824_01/html/E26033/glset.html or https://github.com/faker-js/faker/tree/next/src/locales for locales? |
Created PR for feedback #826. |
Create locale enum like in faker.js
In this issue just create a enum type that contains all values below, for USA which uses english language it would be
en_US
value, so _from values:
The text was updated successfully, but these errors were encountered: