-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix codecov #598
Comments
probably tests directory cmakelists should be included in main cmakelists before sources in the beginning of the file (not in the end) |
I can take a look in this one. I used to use codecov in past projects. Now with Github marketplace and app integration, it's much straightforward than before. |
I was doing little investigation in my past projects that have codecov working well and I see the difference that in here we link from fakerUT to faker and back then I added sources with ut sources to UT executable definition. Maybe it will be helpful |
I merged PR and set token env but it outputs some error:
|
@cieslarmichal I didn't see the coverage step in clang build 😞 Anyway, I removed it on this new PR #776. Still, we are running and is working on static analysis build. Also, you have to configure the codecov token, the CI reported that's missing: https://github.com/cieslarmichal/faker-cxx/actions/runs/9768106754/job/26964867122#step:13:34 The instructions to add the token are listed here: https://app.codecov.io/gh/cieslarmichal/faker-cxx/settings |
I added CODECOV_TOKEN secret so I don't know why it doesnt find it, will check it later |
I think it works now: https://app.codecov.io/github/cieslarmichal/faker-cxx |
Code coverage is currently somehow broken and only shows code coverage in tests files, not in source files.
The text was updated successfully, but these errors were encountered: