Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codecov #598

Closed
cieslarmichal opened this issue May 28, 2024 · 8 comments · Fixed by #773
Closed

fix codecov #598

cieslarmichal opened this issue May 28, 2024 · 8 comments · Fixed by #773
Assignees
Labels
good first issue Good for newcomers high priority High priority

Comments

@cieslarmichal
Copy link
Owner

Code coverage is currently somehow broken and only shows code coverage in tests files, not in source files.

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label May 28, 2024
@cieslarmichal
Copy link
Owner Author

probably tests directory cmakelists should be included in main cmakelists before sources in the beginning of the file (not in the end)

@cieslarmichal cieslarmichal added the high priority High priority label Jun 27, 2024
@cieslarmichal cieslarmichal linked a pull request Jun 29, 2024 that will close this issue
@uilianries
Copy link
Contributor

I can take a look in this one. I used to use codecov in past projects. Now with Github marketplace and app integration, it's much straightforward than before.

@cieslarmichal
Copy link
Owner Author

I was doing little investigation in my past projects that have codecov working well and I see the difference that in here we link from fakerUT to faker and back then I added sources with ut sources to UT executable definition. Maybe it will be helpful

@cieslarmichal
Copy link
Owner Author

I merged PR and set token env but it outputs some error:

==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4.0.1/dist/codecov do-upload'
/home/runner/work/_actions/codecov/codecov-action/v4.0.1/dist/codecov do-upload
info - 2024-07-02 22:35:52,721 -- ci service found: github-actions
warning - 2024-07-02 22:35:52,731 -- xcrun is not installed or can't be found.
warning - 2024-07-02 22:35:52,754 -- No gcov data found.
warning - 2024-07-02 22:35:52,755 -- coverage.py is not installed or can't be found.
info - 2024-07-02 22:35:52,806 -- Found 0 coverage files to report
Error: No coverage reports found. Please make sure you're generating reports successfully.

@cieslarmichal
Copy link
Owner Author

@uilianries
Copy link
Contributor

@cieslarmichal I didn't see the coverage step in clang build 😞

Anyway, I removed it on this new PR #776. Still, we are running and is working on static analysis build.

Also, you have to configure the codecov token, the CI reported that's missing: https://github.com/cieslarmichal/faker-cxx/actions/runs/9768106754/job/26964867122#step:13:34

The instructions to add the token are listed here: https://app.codecov.io/gh/cieslarmichal/faker-cxx/settings

@cieslarmichal
Copy link
Owner Author

I added CODECOV_TOKEN secret so I don't know why it doesnt find it, will check it later

@cieslarmichal
Copy link
Owner Author

I think it works now: https://app.codecov.io/github/cieslarmichal/faker-cxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers high priority High priority
Projects
None yet
2 participants