Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor weather module data #581

Closed
cieslarmichal opened this issue May 24, 2024 · 1 comment · Fixed by #612
Closed

refactor weather module data #581

cieslarmichal opened this issue May 24, 2024 · 1 comment · Fixed by #612
Labels
good first issue Good for newcomers

Comments

@cieslarmichal
Copy link
Owner

Move all module data into Data.h and Data.cpp next to .cpp, use std::array, std::string_view, std::unordered_map for data definitions, reference Airline module data.
@cieslarmichal cieslarmichal added the good first issue Good for newcomers label May 27, 2024
@krupalbhat
Copy link
Contributor

i would like to work on this issue

@krupalbhat krupalbhat mentioned this issue May 31, 2024
Merged
@cieslarmichal cieslarmichal linked a pull request May 31, 2024 that will close this issue
refactor weather data #612
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor weather data krupalbhat/faker-cxx
2 participants
@cieslarmichal @krupalbhat