Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor person module data #573

Closed
cieslarmichal opened this issue May 24, 2024 · 0 comments · Fixed by #627
Closed

refactor person module data #573

cieslarmichal opened this issue May 24, 2024 · 0 comments · Fixed by #627
Assignees
@cieslarmichal
Labels
good first issue Good for newcomers

Comments

@cieslarmichal
Copy link
Owner

Move all module data into Data.h and Data.cpp next to .cpp, use std::array, std::string_view, std::unordered_map for data definitions, reference Airline module data.
@cieslarmichal cieslarmichal added the good first issue Good for newcomers label May 24, 2024
@cieslarmichal cieslarmichal self-assigned this Jun 2, 2024
@cieslarmichal cieslarmichal linked a pull request Jun 2, 2024 that will close this issue
refactor person module data #627
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cieslarmichal cieslarmichal

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor person module data cieslarmichal/faker-cxx
1 participant
@cieslarmichal