Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add location addresses data from Israel #459

Closed
cieslarmichal opened this issue Jan 14, 2024 · 17 comments · Fixed by #972
Closed

Add location addresses data from Israel #459

cieslarmichal opened this issue Jan 14, 2024 · 17 comments · Fixed by #972
Assignees
@zoearose
Labels
good first issue Good for newcomers

Comments

@cieslarmichal
Copy link
Owner

No description provided.

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Jan 14, 2024
@SayeedKhan21
Copy link
Contributor

SayeedKhan21 commented Jan 23, 2024 •
edited
Loading

hey @cieslarmichal I think as a first contribution I will start with this issue . I just wanted to ask how do fetch all the cities, states, prefixes accurately ? Like is there any specific website /api through which gather all this info ?

@cieslarmichal
Copy link
Owner Author

Hello, here you go:
https://github.com/faker-js/faker/tree/next/src/locales/he/location

@cieslarmichal
Copy link
Owner Author

Consider giving a star to the repository to make this project more popular 🌟

@SayeedKhan21
Copy link
Contributor

hey @cieslarmichal could you tell me what do these folders mean ? Like what does the "he" folder here contain ?

@cieslarmichal
Copy link
Owner Author

He is for hebrew language - Israel. It contains all location data needed here.

@SayeedKhan21
Copy link
Contributor

do u have a reference of the same as well ? Like you mentioned he is for hebrew , similarly other folders also mean something or the other , so u like do have a file containing all such stuff/mappings ? It would be great in that case

@cieslarmichal
Copy link
Owner Author

In fakerjs in each folder there is a metadata file which contains info which country and language it s about, but I am now aware of general mapping for list of countries

@SayeedKhan21
Copy link
Contributor

@cieslarmichal what files are expected in israel folder in /location/data/israel ? Israelcities , Israelstates and ? . Should i take up all the related files in fakerjs he folder ? https://github.com/faker-js/faker/tree/next/src/locales/he/location

@cieslarmichal
Copy link
Owner Author

Look for example in https://github.com/cieslarmichal/faker-cxx/tree/main/src/modules/location/data/poland
and add corresponding definitions but for Israel.

@SayeedKhan21
Copy link
Contributor

@cieslarmichal Vscode is not rendering the hebrew names properly on my system . I actually wanted to add double quotes to all names as per done in all the files and while doing so I realized that some of the names are not getting rendered properly . Any suggestions on this ?

@cieslarmichal
Copy link
Owner Author

Yes, what file encoding do you have in your file? It should be utf8 as I remember

@SayeedKhan21
Copy link
Contributor

Its UTF-8 itself . How do you double quote entire ts file ? Any specific method that u use ?

@cieslarmichal
Copy link
Owner Author

I dont uderstand it I guess, could you give me more detailed explaination? With examples etc

@SayeedKhan21
Copy link
Contributor

Can i dm you on discord ?

@cieslarmichal
Copy link
Owner Author

Sure

@cieslarmichal cieslarmichal reopened this Jun 20, 2024
@zoearose
Copy link
Contributor

Could I work on this?

@cieslarmichal
Copy link
Owner Author

Sure go ahead! Assigned

zoearose added a commit to zoearose/faker-cxx that referenced this issue Oct 31, 2024
@zoearose
feat: Added Israel location data (cieslarmichal#459)
5f9c8d0 
* Update location.cpp
* Update location_data.h
* Update location_test.cpp
* Run format_code script

fix: typos & formatting issues due to the language being read Right to Left

* Update location_test.cpp
* Add Israel data to switch case
* fix: location_test.cpp
@cieslarmichal cieslarmichal linked a pull request Oct 31, 2024 that will close this issue
feat: Added Israel location data (#459) #972
Merged
cieslarmichal pushed a commit that referenced this issue Nov 1, 2024
@zoearose
feat: Added Israel location data (#459) (#972)
716b6be 
* feat: Added Israel location data (#459)

* Update location.cpp
* Update location_data.h
* Update location_test.cpp
* Run format_code script

fix: typos & formatting issues due to the language being read Right to Left

* Update location_test.cpp
* Add Israel data to switch case
* fix: location_test.cpp

* fix: add build artifacts to .gitignore and remove from tracking
chore: remove temporary test log files from commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoearose zoearose

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added Israel location data (#459) zoearose/faker-cxx
3 participants
@cieslarmichal @SayeedKhan21 @zoearose