Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add location addresses data from Palestine #458

Closed
cieslarmichal opened this issue Jan 14, 2024 · 6 comments · Fixed by #977
Closed

Add location addresses data from Palestine #458

cieslarmichal opened this issue Jan 14, 2024 · 6 comments · Fixed by #977
Assignees
@charan-003
Labels
good first issue Good for newcomers

Comments

@cieslarmichal
Copy link
Owner

No description provided.

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Jan 14, 2024
@cieslarmichal cieslarmichal reopened this Jun 20, 2024
@layasri157
Copy link

please assign it to me

@cieslarmichal
Copy link
Owner Author

Assigned

@charan-003
Copy link
Contributor

i want to work on it

@cieslarmichal
Copy link
Owner Author

Assigned

@charan-003
Copy link
Contributor

just want to confirm, this is to be done in location_data.cpp right

@cieslarmichal
Copy link
Owner Author

Yes and it to switch statement like any other location data in location.cpp and location_test.cpp and add test for it

@cieslarmichal cieslarmichal linked a pull request Nov 15, 2024 that will close this issue
feat: added Palestine location data #977
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charan-003 charan-003

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added Palestine location data charan-003/faker-cxx
3 participants
@cieslarmichal @charan-003 @layasri157