Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add location addresses data from Macedonia #447

Open
cieslarmichal opened this issue Jan 14, 2024 · 5 comments · May be fixed by #1013
Open

Add location addresses data from Macedonia #447

cieslarmichal opened this issue Jan 14, 2024 · 5 comments · May be fixed by #1013
Assignees
@mayakost
Labels
good first issue Good for newcomers

Comments

@cieslarmichal
Copy link
Owner

No description provided.

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Jan 14, 2024
@cieslarmichal cieslarmichal reopened this Jun 20, 2024
@mayakost
Copy link

mayakost commented Dec 7, 2024

Can this be assigned to me as my first contribution?

@cieslarmichal
Copy link
Owner Author

Yes sure, assigned

@cieslarmichal
Copy link
Owner Author

Its a namespace like reference uuid, like in example 0fa41ccd-ae34-46a8-94fd-c167f2cf9394, it could, take it as params input and namespace

@cieslarmichal
Copy link
Owner Author

But i guess then it needs to be separated method as current uuid does not have any params

@cieslarmichal
Copy link
Owner Author

Then we can refactor to create function for each uuid version :)

@cieslarmichal cieslarmichal linked a pull request Dec 9, 2024 that will close this issue
feat: Macedonia location data updated #1013
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayakost mayakost

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Macedonia location data updated mayakost/faker-cxx
2 participants
@cieslarmichal @mayakost