Publish on package manager repository - vcpkg

[ASil-Scanway]

I'd like to request to publish the package on vcpkg repository to enable seamless integration with projects using this package manager.

[cieslarmichal]

Thanks for raising the issue! I will take care of that

[wsekta]

I could take this issue

[mostsignificant]

I am currently working on this, I need some changes in the CMakeLists.txt (mainly install) and then I could publish a port on vcpkg, which includes a patch for the CMakeLists to use fmt from vcpkg if using the faker-cxx via vcpkg. If interested, I can submit a PR but I need a CMake guru to review it since my CMake understanding is limited

[cieslarmichal]

I am not a guru but I will try to review it :)

[cieslarmichal]

Hello @mostsignificant are you working on this?

[mostsignificant]

@cieslarmichal Yes, please review my PR - some little caveats though, especially on MacOS X

[cieslarmichal]

looks good, merged :) what are next steps here?

[cieslarmichal]

good job 🔥

[mostsignificant]

I will submit a PR for vcpkg tomo, I have already prepared the files (vcpkg.json, portfile.cmake, usage, and two patch files) for a port. If accepted, I will add a section about vcpkg in your README

[mostsignificant]

Okay, I already opened the Draft PR, you can check it out here: microsoft/vcpkg#38583

[cieslarmichal]

Nice

[AdamJovanovic]

Would it make sense for googletest to also be a dependency of faker-cxx when using vcpkg?

[cieslarmichal]

Good question, I don't think we need that there

[mostsignificant]

We could add it as vcpkg port "feature" - which means you could build with tests enabled and it also includes googletest in this case. I am not sure about doing the same for fmt so users must only activate it when doing a Apple clang 12 build

[mostsignificant]

Almost finished with the initial version, but I need some help here:
https://github.com/microsoft/vcpkg/pull/38583/files/64afeaec8a9f0f3cddd3b309f25851dfd6c9f9f7#diff-589dc7ff9a891c76d3949346ccbe3848bd4289668fde9f8c0cc4bbd2ce04a3ef

Does this mean that faker-cxx needs an extra Config.cmake file? In this case I would need to create them in faker-cxx first and then the referenced version in the vcpkg ports needs to be updated. But I don't know how to write those config.cmake files, I initially thought the install commands in the CMakeLists.txt file take care of it

[cieslarmichal]

Hey, honestly I have no idea how to deal with it. I will ask in our discord channel.

[AdamJovanovic]

I'm having a read of this right now CMake Export Configuration
Still trying to figure it out, but it seems like it's along the lines of what we need to fix. Posting it incase you guys understand it better

[icyfox168168]

请继续这工作，vcpkg真很方便