Some tests can fail in date module

[Globostofo]

Since the data in the tests is chosen randomly, it's possible for a test not to work every time, and for a bug to remain undiscovered if the tests are only run a few times.

The following test failed while I was coding other tests for issue #153:

[ RUN      ] DateTest.shouldGenerateBirthDateByRangeYear
/path/faker-cxx/src/modules/date/DateTest.cpp:150: Failure
Expected: (birthdate.tm_year + 1900) >= (1990), actual: 1989 vs 1990

In theory it's not my code that's causing it to fail, but I'm still investigating to be sure.

[Globostofo]

By spamming make test command, I've managed to find another test from the date module that sometimes fails:

[ RUN      ] DateTest.shouldGenerateBirthDateByExactYear
/home/plouc/faker-cxx/src/modules/date/DateTest.cpp:141: Failure
Expected equality of these values:
  birthdate.tm_year + 1900
    Which is: 1995
  1996

I'm continuing to investigate the source of the problem.

[cieslarmichal]

Ok thanks for investigating that, I will take a look.

[Globostofo]

I found the problem!

In this function, the tm_mday attribute is set to 0 for the lower bound (line 87). However, a month starts on the 1st, so the lower bound is set to midnight on 31 December when it should be on 1 January at midnight.

When I print the lower bound I got this:

1995-12-31 00:00:00.000000000

But we want to have this:

1996-01-01 00:00:00.000000000

Setting the variable to 1 instead of 0 definitely solves the problem. I'll do the PR.

[cieslarmichal]

Good job, I was also looking at the problem right now, and there was a problem with parsing ISO date in tests in parseISOFormattedStringToTm() and parseISOFormattedStringToTimePoint() functions, I fixed it: #168. It took local time instead of UTC and shifted hours but we dont want that,

So we managed to find two bugs in there, nice 😄

[cieslarmichal]

Marking as resolved