-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add uuidv5 function to String module #1005
Comments
ref #1004 |
Well we have some implementations in crypto module but its sha256, we can add sha1 there as well, copy paste from some online resources and add annotation about the source as we cannot use any external libs |
any specific reason why can't we use external libs? |
Yup, people want to use libs with as little dependencies as possibile |
Example when i was starting this project I had boost and people were saying cool lib but there is boost deps I wont use it 😁 |
for uuidV5 , what's "some data" in "SHA1 hash of some data" ? is it a random data ? |
uuidv5 function should take two input arguments, one data which user passes like some string and the second is a namespace which is a reference uuid user can also pass but it is optional and we can set it default to "bfd98c8e-48c0-46af-bf44-255d24883f8f" |
Implementation for UUID5 is done. can you please check if anything needs to be changed ? |
Could you please raise a pull request, it would be easier to review :) |
The text was updated successfully, but these errors were encountered: