Draft: Add support for PBR maps (specular, normal, metalness, roughness, emittance) #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working as intended. Looks really cool |
leMaik
force-pushed
the
pbr
branch
2 times, most recently
from
872c126 to
cad3809
Compare
leMaik
force-pushed
the
pbr
branch
2 times, most recently
from
eef4b36 to
f729150
Compare
…ardless of what textures were loaded before.
… use with specular maps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on this for a while (since christmas 2020), it actually took so long that I added support for metalness and roughness in the meantime. The normal mapping only recently became feasible after switching to normalized quad block models.
For testing, launch with:
-Dchunky.pbr.specular=labpbr(default) or-Dchunky.pbr.specular=oldpbr-Dchunky.pbr.normal=labpbror-Dchunky.pbr.normal=oldpbrThe maps are multiplied to the Material settings, so you'll have to set specular, emittance and metalness to 1 for all blocks and smoothness to 0 (ie. roughness to 1). You can launch Chunky with
-Dchunky.pbr.updateMaterialDefaults=trueto do that.Mixing PBR formats is not yet supported (we need some way to specify that per resourcepack).