Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gradle #1270

Merged
merged 5 commits into from
Apr 4, 2023
Merged

Update Gradle #1270

merged 5 commits into from
Apr 4, 2023

Conversation

ShirleyNekoDev
Copy link
Member

@ShirleyNekoDev ShirleyNekoDev commented May 21, 2022 •
edited
Loading

Upgrade Gradle 7.4 -> 8.0.2
see https://gradle.org/releases/ for changelogs

@ShirleyNekoDev ShirleyNekoDev changed the title Dependency and Gradle upgrades Update Gradle Jul 21, 2022
@ShirleyNekoDev
Copy link
Member Author

Something something packages not found 🤔

@leMaik
Copy link
Member

leMaik commented Aug 1, 2022

We could merge this, but the build needs to be fixed 🤷‍♂️

@NotStirred
Copy link
Member

NotStirred commented Mar 31, 2023 •
edited
Loading

Relevant issue for build failure openjfx/javafx-gradle-plugin#140

@ShirleyNekoDev
Copy link
Member Author

ShirleyNekoDev commented Apr 3, 2023 •
edited
Loading

This should now be ready 🎉
Once we move on to Java 17 or newer (without breaking existing users' setups), we can also update the class file targetCompatability and sourceCompatibility, as well as the JavaFX library.

PS: Thank you @NotStirred for fixing the JavaFX plugin Gradle issue!

@leMaik leMaik merged commit ab1d4a0 into chunky-dev:master Apr 4, 2023
@ShirleyNekoDev ShirleyNekoDev deleted the dependency-upgrades branch April 4, 2023 09:15
leMaik pushed a commit to leMaik/chunky that referenced this pull request Sep 9, 2023
@NotStirred @leMaik
Update to Gradle 8.0.2 (chunky-dev#1270)
e9522f1 
* Upgrade Gradle 7.4 -> 7.5

* Update to gradle 8.0.2

* Work around extension issue in javafx plugin openjfx/javafx-gradle-plugin#140

* updated Gradle plugins, removed unnecessary compile flag override

---------

Co-authored-by: Tom Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShirleyNekoDev @leMaik @NotStirred