Y min/max clip (re)loading inconsistencies

[jackjt8]

Affected versions - 2.5.0-51-gad88ccd7, 2.4.2-21-g1304a5fe, 2.4.2, 2.5.0-SNAPSHOT.75.g8bd287901
Unaffected versions - 2.5.0-15-g1ba5d5b
Exported region from a World Painter world - Kingdom of Galekin_bug.zip

Steps to reproduce:

1. Select a 1.18 world with terrain that is above Y 256.
2. Set Y min clip to -64 and Y max clip to 320.
3. Look for anomalies in Map View and select them; such as:
   
4. Load selected chunks and observe behaviour:
   

• Load selected chunks mixes Chunk loading at Y clip 0<Y<256 and -64<Y<320 (see above).
• Using Reload chunks slices the terrain back down to 0<Y<256:
  

---

Alternative steps:

1. Select a 1.18 world with terrain that is above Y 256.
2. Do NOT alter Y min/max clip (ie leave at 0,256).
3. Select and Load selected chunks.
4. Alter, set Y min/max clip to -64,320.
5. Reload chunks.
6. Also cry here because you had it working doing it this way before.

---

And when it magically works... (Not actually sure the exact steps to do this and it breaks very easily...)

---

Additional information - This issue is selection dependant. Below you will see one region vs two chunks without moving the camera. (2.5.0)


(2.4.2)

---

2.5.0-15-g1ba5d5b renders Map View correctly:

2.5.0-15-g1ba5d5b also correctly renders the chunks:

[Peregrine05]

Does this happen in Stable Snapshot or previous snapshots?

[jackjt8]

Does this happen in Stable Snapshot or previous snapshots?

Stable Snapshot. I have only got 2.5.0-15 and 2.5.0-51 to hand.

[jackjt8]

Unfixed after #1197 via 2.5.0-SNAPSHOT.75.g8bd28790

Should be noted that #1197 seems to have resolved the selection dependant issues; All chunks are now cut to Y max clip = 256 regardless of whether or not the chunks have data above this and Y max clip is set to 320. Map view renders correctly.

[leMaik]

@jackjt8 This issue is partially caused by the octree overflowing (fixed by #1768) and the chunk data version being incorrect (fixed by #1466). Could you test this against the latest (ie. 611bd42 or later) build of #1466? 🙏

[NotStirred]

in my testing this world loads fine now on master and #1466, though more testing is always good