-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scene Description Format issues #1069
Comments
|
|
Found another oddity: The beacon beam entity stores its color as an integer. I'm currently improving the scene format such that anything that is called |
I updated the checkboxes above to reflect the changes in #1784, which is now finished. The serialization of colors can be toggled by setting the |
mode
(ie{"SIMULATED", "SOLID_COLOR", “GRADIENT”, “SKYMAP_PANORAMIC”, “SKYMAP_SPHERICAL”, “SKYBOX”, “BLACK”}
)BLACK
is redundant. We do not need it asSOLID_COLOR
with rgb(0,0,0) works fine. It is one thing to have redundant options in the UI but we should not also write this to the SDF.color
is not an RGB object like othercolor
keys. It is instead an array of three numbers with nored
,green
, andblue
keys. This is not consistent.rgb
key and uses hex codes. This is not consistent.Camera Object: name
with values of Camera Object. Why not just an array of Camera Objects? We do not need to have keys set to thename
from within the value. May also be worth movingcamera
into this new array as having Camera Objects in two places like this is a weird decision.Or, as described much better with an example:
"Peregrine05 — Today at 15:58
What if we have cameras as an array of dictionaries (camera objects), and have a separate selectedCamera key that is just the name of the selected camera?
"
The text was updated successfully, but these errors were encountered: