Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: Missing Charmed effect name and image #42

Open
Cicopath opened this issue Aug 14, 2024 · 1 comment
Open

[Bug Report]: Missing Charmed effect name and image #42

Cicopath opened this issue Aug 14, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Cicopath
Copy link
Contributor

Describe the bug; What happened?

The Charmed effect is missing its name and image.
image (via JEED)

Expected Behavior

The Charmed effect should be named "Charmed" and have an image associated with the effect.

Mod Version

Fabric 1.20.1; mod version 4.0.3

Minecraft Launcher

CurseForge

Operating System

Windows

Modpack

Creating my own

Additional context

Seems that the Charmed effect name was never added to the language file: https://github.com/chronosacaria/MCDungeonsArtifacts/blob/1.20/src/main/resources/assets/mcdar/lang/en_us.json#L51. Also apparent for the other language files.

There also doesn't seem to be an image for the Charmed effect: https://github.com/chronosacaria/MCDungeonsArtifacts/blob/1.20/src/main/resources/assets/mcdar/textures/mob_effect/charmed.png.

@chronosacaria
Copy link
Owner

@Cicopath Yeah, that is fair. Since it is never player facing, we didn't make an icon or translate it, but in the interest of best practices, we really should. Thanks for opening an issue about this

@chronosacaria chronosacaria added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants