Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromaui/action skipping rebuild omit output prop storybookUrl #983

Open
matthprost opened this issue May 14, 2024 · 2 comments
Open

chromaui/action skipping rebuild omit output prop storybookUrl #983

matthprost opened this issue May 14, 2024 · 2 comments
Labels
bug Classification: Something isn't working CLI Empathy

Comments

@matthprost
Copy link

matthprost commented May 14, 2024

Bug report

Hello!

I recently faced an issue with chromaui/action@v11. When no rebuild is needed I have the following output:

Skipping rebuild of an already fully passed/accepted build

For now, no problem for me this seems fair. The issue with this is that when the build is skipped like so, the github action does not provide storybookUrl as output as it usually does. This leads to issues for us as we need it to display a deployment button on our pull requests with the storybookUrl.

The workaround I found is to pass forceRebuild: true as input as seen on this PR, but it might not be the best way to do it. I think there is an issue with the github action not providing the correct output especially storybookUrl.

The issue can be found on our github actions here: https://github.com/scaleway/ultraviolet/actions/runs/9077521594/job/24956851613?pr=3773
Screenshot 2024-05-14 at 17 56 00

You can find our config here: https://github.com/scaleway/ultraviolet/blob/d23bfe6332ddff37dbb6f6b28ae6c694a5e838d3/.github/workflows/ci.yml#L160

Where we will get steps.chromatic.outputs.storybookUrl that is undefined when no rebuild is needed but correctly set when the build is needed.

If you need anymore details don't hesitate!

@matthprost matthprost added bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation labels May 14, 2024
@cgbl-90
Copy link

cgbl-90 commented Aug 27, 2024

hey @matthprost I believed this behaviour is set by default for no rebuilds, but let me discuss it internally.

have you tried this workaround: https://www.chromatic.com/docs/faq/get-published-storybook-url-via-ci/?

@andresilva-yld
Copy link

Hi @cgbl-90 Any movement on this issue?

I'm also trying to understand how to work around the fact that the GH action doesn't fail with unreviewed changes, and also doesn't return build info when I re-run the workflow.

Doesn't that make the Chromatic GH action essentially useless? If it can't fail the build and it can't return build info consistently, what is it good for?

@jmhobbs jmhobbs added Empathy and removed needs triage Tracking: Issue needs confirmation labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working CLI Empathy
Projects
None yet
Development

No branches or pull requests

5 participants