You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I recently faced an issue with chromaui/action@v11. When no rebuild is needed I have the following output:
Skipping rebuild of an already fully passed/accepted build
For now, no problem for me this seems fair. The issue with this is that when the build is skipped like so, the github action does not provide storybookUrl as output as it usually does. This leads to issues for us as we need it to display a deployment button on our pull requests with the storybookUrl.
The workaround I found is to pass forceRebuild: true as input as seen on this PR, but it might not be the best way to do it. I think there is an issue with the github action not providing the correct output especially storybookUrl.
I'm also trying to understand how to work around the fact that the GH action doesn't fail with unreviewed changes, and also doesn't return build info when I re-run the workflow.
Doesn't that make the Chromatic GH action essentially useless? If it can't fail the build and it can't return build info consistently, what is it good for?
Bug report
Hello!
I recently faced an issue with
chromaui/action@v11
. When no rebuild is needed I have the following output:For now, no problem for me this seems fair. The issue with this is that when the build is skipped like so, the github action does not provide
storybookUrl
as output as it usually does. This leads to issues for us as we need it to display a deployment button on our pull requests with thestorybookUrl
.The workaround I found is to pass
forceRebuild: true
as input as seen on this PR, but it might not be the best way to do it. I think there is an issue with the github action not providing the correct output especiallystorybookUrl
.The issue can be found on our github actions here: https://github.com/scaleway/ultraviolet/actions/runs/9077521594/job/24956851613?pr=3773
You can find our config here: https://github.com/scaleway/ultraviolet/blob/d23bfe6332ddff37dbb6f6b28ae6c694a5e838d3/.github/workflows/ci.yml#L160
Where we will get
steps.chromatic.outputs.storybookUrl
that isundefined
when no rebuild is needed but correctly set when the build is needed.If you need anymore details don't hesitate!
The text was updated successfully, but these errors were encountered: