Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Chromatic UI review to ignore tag comments #696

Open
dgonzalezr opened this issue Dec 12, 2022 · 1 comment
Open

[Question] Chromatic UI review to ignore tag comments #696

dgonzalezr opened this issue Dec 12, 2022 · 1 comment
Labels
bug Classification: Something isn't working CLI needs triage Tracking: Issue needs confirmation

Comments

@dgonzalezr
Copy link

Question

We use lit-HTML on our storybook stories, unfortunately whenever the storybook gets compiled, lit will add a tag comment with an identifier on the SB stories. Is there a way to tell chromatic to ignore them? Because they are seen as changes on multiple SB stories that are not related to the changes in the matter 😞

CleanShot 2022-12-12 at 19 21 38

@dgonzalezr dgonzalezr added bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation labels Dec 12, 2022
@dgonzalezr dgonzalezr changed the title Chromatic UI review to ignore tag comments [Question] Chromatic UI review to ignore tag comments Dec 12, 2022
@winkerVSbecks
Copy link
Member

You can ignore certain DOM elements: https://www.chromatic.com/docs/ignoring-elements/#ignore-dom-elements

But Chromatic only flags changes if there are visual changes in snapshot. The DOM diff should not trigger a change is the story doesn't change visually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working CLI needs triage Tracking: Issue needs confirmation
Projects
None yet
Development

No branches or pull requests

3 participants