Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Delete collection resource leak (single-node Chroma) #3297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUG]: Delete collection resource leak (single-node Chroma) #3297

wants to merge 1 commit into from
+74 −12

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Dec 13, 2024 •
edited
Loading

Description of changes

Closes #3296

The delete collection logic slightly changes to accomodate the fix without breaking the transactional integrity of self._sysdb.delete_collection. The chromadb.segment.SegmentManager.delete_segments had to change to accept the list of segments to delete instead of collection_id.

image

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fixes the resource leak when deleting a collection

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tazarov Graphite App
Copy link
Contributor Author

tazarov commented Dec 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tazarov tazarov added bug Something isn't working Local Chroma An improvement to Local (single node) Chroma labels Dec 16, 2024
@tazarov tazarov mentioned this pull request Dec 19, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitcpbot rohitcpbot Awaiting requested review from rohitcpbot

@HammadB HammadB Awaiting requested review from HammadB

Assignees
No one assigned
Labels
bug Something isn't working Local Chroma An improvement to Local (single node) Chroma
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Resource leak in delete_collection (Single-Node Chroma)
1 participant
@tazarov