From f42567e976ca562ccc79b4d2ebc50d08605de6ae Mon Sep 17 00:00:00 2001 From: Hammad Bashir Date: Mon, 29 Apr 2024 11:10:40 -0700 Subject: [PATCH] [BUG] GRPC Metadata segment should return results (#2073) ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Fixes a bug where the segment was returning an empty [] despite constructing the correct result - New functionality - None ## Test plan *How are these changes tested?* We should have a test for this! For now I am getting the bug fix up and we can discuss how to test. - [!!!!] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None --- chromadb/segment/impl/metadata/grpc_segment.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chromadb/segment/impl/metadata/grpc_segment.py b/chromadb/segment/impl/metadata/grpc_segment.py index b9dd9d879b8..0d38c48796b 100644 --- a/chromadb/segment/impl/metadata/grpc_segment.py +++ b/chromadb/segment/impl/metadata/grpc_segment.py @@ -89,7 +89,7 @@ def get_metadata( result = self._from_proto(record) results.append(result) - return [] + return results def _where_to_proto(self, where: Optional[Where]) -> pb.Where: response = pb.Where()