From 3458cb5a0e2fb16ddfe64bfa03605a807174ef15 Mon Sep 17 00:00:00 2001 From: Sanket Kedia Date: Thu, 5 Dec 2024 14:48:27 -0800 Subject: [PATCH] Review comments --- rust/worker/src/execution/operators/spann_bf_pl.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rust/worker/src/execution/operators/spann_bf_pl.rs b/rust/worker/src/execution/operators/spann_bf_pl.rs index 5fea57e0235f..6a2f997e23ff 100644 --- a/rust/worker/src/execution/operators/spann_bf_pl.rs +++ b/rust/worker/src/execution/operators/spann_bf_pl.rs @@ -13,6 +13,7 @@ use super::knn::RecordDistance; #[derive(Debug)] pub struct SpannBfPlInput { + // TODO(Sanket): We might benefit from a flat structure which might be more cache friendly. // Posting list data. posting_list: Vec, // Number of results to return. @@ -25,6 +26,7 @@ pub struct SpannBfPlInput { query: Vec, } +#[allow(dead_code)] #[derive(Debug)] pub struct SpannBfPlOutput { records: Vec, @@ -42,6 +44,7 @@ impl ChromaError for SpannBfPlError { #[derive(Debug)] pub struct SpannBfPlOperator {} +#[allow(dead_code)] impl SpannBfPlOperator { pub fn new() -> Box { Box::new(SpannBfPlOperator {})