From bd4779d22ce7834ca7f837d6022bc94d49be7bee Mon Sep 17 00:00:00 2001 From: Chris Vogt Date: Sun, 2 Jun 2024 17:35:16 -0700 Subject: [PATCH 1/2] fix: space sometimes visible below header swoop --- theme/src/components/swoops/swoop-bottom.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/theme/src/components/swoops/swoop-bottom.js b/theme/src/components/swoops/swoop-bottom.js index a92126d5..3f30c277 100644 --- a/theme/src/components/swoops/swoop-bottom.js +++ b/theme/src/components/swoops/swoop-bottom.js @@ -11,9 +11,13 @@ export default ({ fill }) => { preserveAspectRatio='xMidYMin slice' xmlns='http://www.w3.org/2000/svg' viewBox='0 0 1366 63' + height='auto' sx={{ fill: fill || defaultFillColor, - verticalAlign: 'bottom' + verticalAlign: 'bottom', + // Hack to fix a bug in some browser where a fraction of a pixel + // of space is sometimes rendered below the swoop + marginBottom: '-1px' }} > Date: Sun, 2 Jun 2024 17:41:20 -0700 Subject: [PATCH 2/2] SQUASHME: fixup tests --- theme/src/components/__snapshots__/header.spec.js.snap | 3 ++- .../components/swoops/__snapshots__/swoop-bottom.spec.js.snap | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/theme/src/components/__snapshots__/header.spec.js.snap b/theme/src/components/__snapshots__/header.spec.js.snap index aeac9604..69c4044a 100644 --- a/theme/src/components/__snapshots__/header.spec.js.snap +++ b/theme/src/components/__snapshots__/header.spec.js.snap @@ -10,7 +10,8 @@ exports[`Header matches the snapshot 1`] = ` Wow!