Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading zip #207

Open
Andarist opened this issue Jan 5, 2017 · 3 comments
Open

Downloading zip #207

Andarist opened this issue Jan 5, 2017 · 3 comments

Comments

@Andarist
Copy link

Andarist commented Jan 5, 2017

Downloading zip file downloads a template of configs and index files etc + the written code.

The problem is that it cannot be 'just ran' because i.e. entry point file name is not updated in the webpack.config.js.

I could attempt to fix the issue, just needs some guidance for the approach I should use, as I'm not familiar with the codebase.

Also the version I've downloaded didnt have babel-core in its devDependencies (although it should have), but from what I see its fixed in the source code. But was the fix released?

@nabiltntn
Copy link

Yes, the downloaded version does not have babel-core as dev dependencies. But no problem with entry point file.

@Andarist
Copy link
Author

Andarist commented Jan 8, 2017

maybe if your entry point's name matches the default (main.js), i've called mine index.js and it wont work obviously with the downloaded webpack.config.js. Here it is for easy check:

var path = require('path');
var webpack = require('webpack');
var HtmlWebpackPlugin = require('html-webpack-plugin');

var loaders = [];

module.exports = {
  devtool: 'eval-source-map',
  entry: path.resolve('src', 'main.js'),
  output: {
    path: path.resolve('build'),
    filename: '[name].js',
    publicPath: '/'
  },
  plugins: [
    new HtmlWebpackPlugin({
      template: path.resolve('src', 'index.tpl.html'),
      inject: 'body',
      filename: 'index.html'
    })
  ],
  module: {
    loaders: loaders
  }
};

@wmertens
Copy link

2 more things: I also needed to add webpack-merge, and when I make changes the project.zip does not get updated, I always get the same one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants