Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to xmonad-contrib (or standalone package)? #4

Open
podiki opened this issue Oct 4, 2020 · 3 comments
Open

add to xmonad-contrib (or standalone package)? #4

podiki opened this issue Oct 4, 2020 · 3 comments

Comments

@podiki
Copy link

podiki commented Oct 4, 2020

Thanks for this great layout, just what I was looking for! Do you have any plans to make this available through xmonad-contrib? Or as some other package (i.e. don't need the full build or xmonad.hs)?

Haven't learned much Haskell yet, but got at least the basic layout working pretty easily. In case it helps anyone, this is what I've done so far:

  1. copy/clone the files from /lib/ to ~/.xmonad/lib
  2. needed lens (in my case using Arch Haskell packages, haskell-lens worked)
  3. needed the line {-# LANGUAGE LambdaCase #-} added to MiddleColumn.hs (didn't work added to my xmonad.hs)
  4. added import MiddleColumn to my xmonad.hs
  5. finally edited my xmonad.hs to include
defaultThreeColumn :: (Float, Float, Float)
defaultThreeColumn = (0.15, 0.65, 0.2)

and added getMiddleColumnSaneDefault 2 0.15 defaultThreeColumn to my layoutHook

@chrissound
Copy link
Owner

I'm not sure what is involved with getting this to xmonad-contrib. I will investigate soon.

Thank you so much for your points mentioned! I need to put a bit attention to getting this repo easily installed.

Regarding point 2, 3 - this should be resolved if you use https://github.com/sol/hpack to generate the cabal file. Really I should include that in the repo as well, but just thought I'd share if it helps.

If you have any questions on anything, I'd be happy to answer!

@podiki
Copy link
Author

podiki commented Oct 4, 2020

Thanks! I haven't (yet) used Cabal/Stack for Xmonad, instead using Arch's packages. So that's why I was just looking for the quickest way for me to try it.

My quick look at contributing looks like checking with xmonad-testing, some straight forward guidelines, and pull request to xmonad-contrib. I'd offer to help, but don't know much Haskell yet. If you need any testing, I can do that.

I'll try out the rest as I need it (looks like other good stuff), but already very happy to have that MiddleColumn layout!

@podiki
Copy link
Author

podiki commented Nov 11, 2020

Small update on my end. I moved to building XMonad with stack (tired of all the Arch haskell package upgrades and rebuilds). I don't think this changes anything I had to do, unless I wanted to use the whole repo as it is (with package.yaml, etc.). I think a minor issue is that cloning into ~/.xmonad/lib, while able to be built by stack, doesn't expose the modules more generally. Is this just a simple issue of the modules being in ~/.xmonad/lib/lib or the naming? In other words, doesn't seem like XMonad will see those modules to import and use, even though subdirectories should be fine (naming?). (I'm very new to stackage, etc., so maybe this is something simple.)

Edit: Yes, appears this won't follow the naming convention expected (capital letter to start, nor does e.g. MiddleColumn if it is in a subdirectory). So probably need to separate out the lib directory with it's own cabal/package file to make it self-contained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants