Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Choice cuts off text with variable width font #1637

Open
pcmdx opened this issue Nov 8, 2024 · 2 comments
Open

Display Choice cuts off text with variable width font #1637

pcmdx opened this issue Nov 8, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@pcmdx
Copy link

pcmdx commented Nov 8, 2024

Describe the bug
For certain strings, the Display Choice event cuts off text even though there's room for the characters.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Display choice even
  2. Type "Seduction book (Atn)"
  3. View the preview of the choice, which shows it fits
  4. Run game, which shows missing characters

Expected behavior
Show all characters up to the end of the popup.

Screenshots
image

Platform (please complete the following information):

  • OS: Linux Mint
  • App version: 4.1.3

Additional context
If I set the project to mono spaced, it cuts the text off at the same character, making me think the Display Choice event is using the wrong code to determine the cut off.

image

@pcmdx pcmdx added the bug Something isn't working label Nov 8, 2024
@chrismaltby
Copy link
Owner

Yeah you were right this was left over cropping from a time when only mono space fonts were supported so cropping was handled automatically. These days most of that auto cropping has been removed and it's up to you to make sure you don't write too much text, I'd just missed removing that that one.

I've fixed here:
ae071b4
which will be included in the next release.

Another option you have rather than updating is to use the "Display Menu" event with the following options which should end up being equivalent but without the cropping
Screenshot 2024-11-09 at 11 12 54

@pcmdx
Copy link
Author

pcmdx commented Nov 9, 2024

Thanks Chris. Appreciate the fix AND the workaround. Your work has helped me release my Death Row game and I'm working on the sequel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants