Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sun.php no longer displays sunrise times, only sunset #21

Open
Ajedi32 opened this issue Sep 26, 2024 · 6 comments
Open

sun.php no longer displays sunrise times, only sunset #21

Ajedi32 opened this issue Sep 26, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Ajedi32
Copy link
Contributor

Ajedi32 commented Sep 26, 2024

I recently noticed that sun.php is no longer showing sunrise times, only sunsets.

This regression seems to be caused by fcbe549 assigning identical UIDs for both the sunrise and sunset events.

@chrisblakley
Copy link
Owner

Thanks for bringing this to my attention– I will look into it as soon as I get a chance!

@chrisblakley chrisblakley added the bug Something isn't working label Sep 27, 2024
@Ajedi32
Copy link
Contributor Author

Ajedi32 commented Oct 1, 2024

Did you just fix something on gearside.com? I don't see any new commits here, but sunrises are showing again, so thanks!

@chrisblakley
Copy link
Owner

chrisblakley commented Oct 1, 2024 via email

@jackdfraser
Copy link

Hi, I am also seeing the bug where it seems to be showing the inverse.

I'll attach some screen shots to clarify what I see.

Screenshot 2024-10-02 at 10 38 56 AM Screenshot 2024-10-02 at 10 40 11 AM

@Ajedi32
Copy link
Contributor Author

Ajedi32 commented Oct 2, 2024

@jackdfraser That seems like a different bug, you might want to open another issue for that. It would also probably help if you shared the exact URL (i.e. the query parameters) you were using to get these results.

@jackdfraser
Copy link

@Ajedi32

fwiw: #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants