Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major memory leaks #40

Open
firasdib opened this issue Sep 28, 2018 · 3 comments
Open

Major memory leaks #40

firasdib opened this issue Sep 28, 2018 · 3 comments

Comments

@firasdib
Copy link
Contributor

You're adding events with specific flags here:

https://github.com/chrisbateman/impetus/blob/master/src/Impetus.js#L194-L198

They need to be removed with the same flags here:

https://github.com/chrisbateman/impetus/blob/master/src/Impetus.js#L238-L242

You must also ensure these events are removed when destroying the instance.

This is a huge issue for us right now and its causing all touch move events to be swallowed up by this, blocking our app.

@firasdib
Copy link
Contributor Author

See #41

@firasdib
Copy link
Contributor Author

Also this:

[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

@weotch
Copy link

weotch commented Jun 4, 2019

@firasdib with the merging of #41, this can be closed now, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants