Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union with prettier-php #15

Open
alexander-akait opened this issue Feb 19, 2018 · 4 comments
Open

Union with prettier-php #15

alexander-akait opened this issue Feb 19, 2018 · 4 comments

Comments

@alexander-akait
Copy link

https://github.com/prettier/plugin-php

@chris-l
Copy link
Owner

chris-l commented Mar 1, 2018

Hi, I'm not sure what this issue is about?
You want to use php-unparser on your prettier plugin?

@alexander-akait
Copy link
Author

@chris-l move best pretty practice in prettier-php 👍

@chris-l
Copy link
Owner

chris-l commented Mar 1, 2018

I'm sorry, I'm not sure if I understand correctly.
I'm guessing that by "pretty practice", you are referring to the pretty printer I created as demo. And you want to use that demo on your prettier-php repo. Is that correct?

By pretty printer demo, I mean this: https://chris-l.github.io/php-unparser/

Well, I'm only using glayzzle's php-parser and my php-unparser for that, so you can just import both php-parser and php-unparser to create a pretty printer.

@alexander-akait
Copy link
Author

alexander-akait commented Mar 1, 2018

@chris-l yes, you have experience with some pretty output using php-parser (as link above), i am glad if you help us (prettier-php) to improve pretty print using you experience here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants