Clear minimap on level load #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using the room property on the sector we can remove the need for the room_info functions on Level. They weren't safe anyway. #1206
When level loads unload map renderer. Don't render map renderer if unloaded. #1206
Set level earlier so the room is cleared. Remove the exposed unload function, not needed #1206
lahm86
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimap wasn't being cleared on level load. VICT.TR2 made this obvious as it had no rooms to to be loaded, so the old room display was still there.
Now when the level loads the minimap is cleared. Some functions to access room info directly from the level have been removed as they are no longer used. It will now take it from the
Sectorinstead of using inidces.Closes #1206