0.9.10 and exit codes

[ferventcoder]

I mentioned this before in April - chocolatey/choco#512. 0.9.10 just released today. This includes the library. As you upgrade, be especially sure to pay attention to this scenario.

Here is the relevant portion of the ChangeLog (under breaking changes):

• Exit with the same exit code as the software being installed - see #512

There are more exit codes from Chocolatey now that indicate success -0, 1605, 1614, 1641, and 3010. You may need to adjust anything you were using that would only check for 0 and nonzero.
If you need the previous behavior, be sure to disable the feature usePackageExitCodes or use the --ignore-package-exit-codes switch in your choco commands.

[ferventcoder]

cc @gep13 @RichiCoder1 (let me know if I got the tags right).

[RichiCoder1]

@ferventcoder We're now checking exit codes to show error messages, so this is very relevant now. Is there a comprehensive lists of "good" codes? If I set --ignore-package-exit-codes can I just keep on using zero and non-zero?

[RichiCoder1]

Or I could tweak lib and add a super secret switch to just have Choco throw exceptions instead of just logging and error and exit code on failure.

[ferventcoder]

You could just use zero or one yes.

[ferventcoder]

The default good exit codes should be listed at the original link.

[RichiCoder1]

Looks like this was completed a while back. We set config.Features.UsePackageExitCodes = false; and check Environment.ExitCode != 0 for failure. Can reevaluate in the future. Sadly I screwed up our history with the subprocess changes, so I can't find the commit.