Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CHIPS fall 2022 tech update to events page + set up multi-branch deployments #13

Closed
robmains opened this issue Jan 24, 2023 · 20 comments

Comments

@robmains
Copy link
Contributor

We should point to forthcoming and archival events on the same page

@robmains
Copy link
Contributor Author

A relevant question is how far back in time should we go in terms of events, that will have to be recovered either from wordpress or otherwise.

@mgielda
Copy link
Member

mgielda commented Jan 27, 2023

We're discussing this in #10

@cjyabraham
Copy link
Collaborator

I've set up the infrastructure for this here: https://chipsalliance.github.io/chips-alliance-website/events/

@robmains
Copy link
Contributor Author

robmains commented Jan 30, 2023 via email

@robmains
Copy link
Contributor Author

robmains commented Jan 30, 2023 via email

@cjyabraham
Copy link
Collaborator

Hi Rob. I have merged your PR. As for the slides, I think we should include them in the GitHub repo to reduce the risk we lose access to them at a later date.

@robmains
Copy link
Contributor Author

robmains commented Jan 31, 2023 via email

@robmains
Copy link
Contributor Author

robmains commented Feb 1, 2023 via email

@cjyabraham
Copy link
Collaborator

It looks like GitHub blocks files larger than 100MB In this case, I think we should just host it on Google Drive and link to it.

@robmains
Copy link
Contributor Author

robmains commented Feb 1, 2023 via email

@robmains
Copy link
Contributor Author

robmains commented Feb 1, 2023 via email

@cjyabraham
Copy link
Collaborator

Hi Rob. I think it'd be good to get preview instances generated for each PR so that they can be more easily reviewed. @mgielda is this something that your team can configure for the repo?

@mgielda
Copy link
Member

mgielda commented Feb 7, 2023

Not sure how to do this, I have:

image

@cjyabraham
Copy link
Collaborator

cjyabraham commented Feb 8, 2023

Perhaps you could try this GH Action as it doesn't look like it's properly available within GH pages yet? Do you intend to keep the production deployment using GH Pages? Or switch to something like Netlify? If Netlify, PR previews would come for free. Here are some other advantages (though the article is a bit old)

@mgielda mgielda changed the title Move CHIPS fall 2022 tech update to events page Move CHIPS fall 2022 tech update to events page + set up multi-branch deployments Feb 10, 2023
@mgielda
Copy link
Member

mgielda commented Feb 12, 2023

@kgugala do or anyone from the team know how we could use GH pages for multi-branch deployments, so that we could see the preview of what the website would look like after a change suggested by e.g. a PR? This would go a long way towards making sure updates don't break the website. I don't want to necessarily migrate to Netlify to achieve that.

@tgorochowik
Copy link
Member

@cjyabraham @mgielda

Please take a look at: #34
I needed to merge it to verify if it works for the reasons mentioned in this PR.

The previews are now deployed at:
https://chipsalliance.github.io/chips-alliance-website/preview/<PR_NUMBER>/

See this PR as an example: #35
and the deployment: https://chipsalliance.github.io/chips-alliance-website/preview/35/about/who-we-are/

Possible next steps (optional):

  • Clean up the preview deployment after closing the PR (or periodically check which ones have been closed and remove their previews)
  • Post a comment in the PR with an URL to the preview

@mgielda
Copy link
Member

mgielda commented Feb 16, 2023

@tgorochowik can you open a separate issue for the potential improvements - then I will close this one.

@cjyabraham
Copy link
Collaborator

These previews no longer seems to work. Here is the preview for PR 40: https://chipsalliance.github.io/chips-alliance-website/preview/40 :
Screen Shot 2023-02-21 at 1 56 44 PM

@tgorochowik
Copy link
Member

It's because of the redirection to chipsalliance.org.
This should fix it: c321561 (note that the pull request will need to be rebased and CI retriggered to make the already deployed previews work)

@mgielda
Copy link
Member

mgielda commented Feb 27, 2023

I think this works, closing.

@mgielda mgielda closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants