Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caliptra allows enough measurements to be stashed to exceed the 2kB certificate threshold within DPE #1832

Open
nquarton opened this issue Dec 3, 2024 · 3 comments

Comments

@nquarton
Copy link
Contributor

nquarton commented Dec 3, 2024

The certificate returned by certify key has a 2kB limit. This limit can be exceeded when stashing more than ~8 measurements.

In fixing this, a test needs to be added that stashes the maximum number of measurements to confirm DPE can support it.

@ericeilertson
Copy link
Contributor

Is the 2kB limit due to a DPE specification limitation, or is this a limit due to our current implementation in Caliptra? I think there are cases we may need to stash a few dozen measurements, so I'd like to see this increased if possible.

@nquarton
Copy link
Contributor Author

Is the 2kB limit due to a DPE specification limitation, or is this a limit due to our current implementation in Caliptra? I think there are cases we may need to stash a few dozen measurements, so I'd like to see this increased if possible.

This was a limit in the DPE implementation. I can't say for sure if this is requiring a spec change. But this size is being increased to 6k in the 1.2 FW to allow for the full 32 measurements.

@jhand2
Copy link
Collaborator

jhand2 commented Dec 20, 2024

It's a profile limitation. It's been increased in both the profile spec & implementation.

Btw, we'll probably need to revisit this again for 2.0. I'm planning some ABI changes to make the sizes more flexible in the next revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants