Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: Superfluous newlines eat up vertical space and make logs hard to read #3850

Closed
hzeller opened this issue Sep 11, 2023 · 1 comment
Closed

Comments

@hzeller
Copy link
Collaborator

hzeller commented Sep 11, 2023

All log messages end with an unnecessary newline. This makes it hard to go through Surelog logfiles as they always use twice the vertical space.

So instead of a log-output like

[INF:CM0023] Creating log file /foo/bar/slpp_all/surelog.log.

[ERR:PP0101] /foo/bar/clk_rst_if.sv:24: Cannot open include file "/foo/bar/hello.svh".

[ERR:PP0101] /foo/bar/clk_rst_if.sv:25: Cannot open include file "/foo/bar/world.svh".

[ERR:PP0102] /foo/bar/clk_rst_if.sv:146:5: Unknown macro "quux".

[ERR:PP0102] /foo/bar/clk_rst_if.sv:160:7: Unknown macro "baz".

This would be much more manageable and readable if we have a log-message per line like other tools do:

[INF:CM0023] Creating log file /foo/bar/slpp_all/surelog.log.
[ERR:PP0101] /foo/bar/clk_rst_if.sv:24: Cannot open include file "/foo/bar/hello.svh".
[ERR:PP0101] /foo/bar/clk_rst_if.sv:25: Cannot open include file "/foo/bar/world.svh".
[ERR:PP0102] /foo/bar/clk_rst_if.sv:146:5: Unknown macro "quux".
[ERR:PP0102] /foo/bar/clk_rst_if.sv:160:7: Unknown macro "baz".
@alaindargelas
Copy link
Collaborator

Fixed by #3889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants