Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint does not hide when aria-label is not present #151

Open
minimih opened this issue Sep 8, 2016 · 6 comments
Open

Hint does not hide when aria-label is not present #151

minimih opened this issue Sep 8, 2016 · 6 comments
Assignees
Labels
good-first-issue If you are yet to contribute to open-source, this issue is a good starting point

Comments

@minimih
Copy link

minimih commented Sep 8, 2016

This hides the Tooltip:
<a class="hint--left" aria-label="">Left</a>

This does not hide the Tooltip:
<a class="hint--top">Top</a>

@chinchang chinchang added the good-first-issue If you are yet to contribute to open-source, this issue is a good starting point label Oct 6, 2021
@sureshkumarAQ
Copy link

could you please assign this task to me I would like to work upon it

@Wimukti
Copy link

Wimukti commented Oct 17, 2021

@chinchang can you assign this to me. I will resolve it

@chinchang
Copy link
Owner

@sureshkumarAQ you still up for fixing this?

@sureshkumarAQ
Copy link

@sureshkumarAQ you still up for fixing this?

Yeah chinchang !! could you please guide me a little bit where to start ? I`m not getting it properly.

@chinchang
Copy link
Owner

@sureshkumarAQ The selectors in the hint-core.scss file will need tweaking. In case the aria-label is empty, the :after element doesn't show because of undefined content value (content: attr(aria-label)). But the :before shows because it has valid content: ''.
To fix this we should change the showing of :after and :before to only when aria-label isn't undefined or empty string.

@mantosh-mariner
Copy link

Hi, I would like to work on this issue. Could you assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue If you are yet to contribute to open-source, this issue is a good starting point
Projects
None yet
Development

No branches or pull requests

5 participants