Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 #111

Merged
merged 44 commits into from
Nov 11, 2023
Merged

v4 #111

merged 44 commits into from
Nov 11, 2023

Conversation

edoardocavazza
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

🦋 Changeset detected

Latest commit: 968e6d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chialab/dna Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 628 lines in your changes are missing coverage. Please review.

Comparison is base (2eb165e) 96.08% compared to head (968e6d6) 70.31%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #111       +/-   ##
===========================================
- Coverage   96.08%   70.31%   -25.77%     
===========================================
  Files          14       12        -2     
  Lines        4619     4241      -378     
  Branches      490      262      -228     
===========================================
- Hits         4438     2982     -1456     
- Misses        180     1063      +883     
- Partials        1      196      +195     
Files Coverage Δ
src/Elements.ts 100.00% <100.00%> (ø)
src/helpers.ts 91.80% <100.00%> (+1.21%) ⬆️
src/Thenable.ts 74.41% <50.00%> (-25.59%) ⬇️
src/css.ts 63.07% <33.33%> (-36.93%) ⬇️
src/Observable.ts 76.11% <46.66%> (-20.94%) ⬇️
src/directives.ts 63.04% <57.14%> (-36.96%) ⬇️
src/Component.ts 83.00% <82.35%> (-11.64%) ⬇️
src/JSX.ts 88.28% <80.07%> (-7.28%) ⬇️
src/events.ts 61.88% <26.31%> (-38.12%) ⬇️
src/property.ts 66.93% <65.04%> (-32.94%) ⬇️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edoardocavazza edoardocavazza changed the title Replace custom shadow dom implementation v4 Oct 2, 2023
@edoardocavazza edoardocavazza merged commit e02d1e5 into main Nov 11, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant