Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtin_marks causes clipping in floating window #79

Open
xbc5 opened this issue Aug 7, 2022 · 2 comments
Open

builtin_marks causes clipping in floating window #79

xbc5 opened this issue Aug 7, 2022 · 2 comments

Comments

@xbc5
Copy link

xbc5 commented Aug 7, 2022

It looks like an extra '.' appears in floating diagnostic windows pushing text to the right and causing clipping. The builtin_marks option is the culprit:

clipping

This appears when using LSP tools like vim.lsp.buf.hover() for example.

Here is a reproduction repo.
@xbc5
Copy link
Author

xbc5 commented Aug 7, 2022

I just realised that is is related to #65. What is the filetype for popups?

xbc5 added a commit to xbc5/nvim that referenced this issue Aug 7, 2022
@xbc5
fix: floating window clipping
c585b51 
Remove marks-nvim since it's unused:
  chentoast/marks.nvim#79

Use glepnir's plug-in again.

Move dap keys to <M-*> maps to free up <leader>* -- LSP keymaps
included.

Squashed commit of the following:

commit 5c440971cf0a6815134c0b03fb48576c129394fe
Author: xbc5 <[email protected]>
Date:   Sun Aug 7 22:45:27 2022 +0100

    remove marks-nvim, it causes clipping for saga previews

commit 97a49dd5a39e42bff9f1f567ca8de149ad20cebb
Author: xbc5 <[email protected]>
Date:   Sat Aug 6 01:31:49 2022 +0100

    tidy up mappings

commit 267b5141ab3691eb11765b3d33fc61553fbea71d
Author: xbc5 <[email protected]>
Date:   Sat Aug 6 01:31:18 2022 +0100

    add implement map

commit 7162de46505541559f89905cb1a25b3fc2ed5131
Author: xbc5 <[email protected]>
Date:   Sat Aug 6 01:18:51 2022 +0100

    map lspsaga useful funcs

commit 7af84d09b692fda7e04dac41cd34b64d027c5a70
Author: xbc5 <[email protected]>
Date:   Sat Aug 6 01:13:14 2022 +0100

    make DAP keys use meta to clear up leader

commit 208d156f7c40912cc1af494125d3396414f37562
Author: xbc5 <[email protected]>
Date:   Sat Aug 6 01:04:04 2022 +0100

    use glepnir's package again
@chentoast
Copy link
Owner

There is no filetype for popups, but you can set an autocmd on WinEnter, and check if your current window is floating via vim.api.nvim_win_get_config(). This will be a suitable workaround for now but I might add a config option that does this in the future.

@benediktms benediktms mentioned this issue Jun 30, 2023
Closed
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chentoast @xbc5