From 7bdbf7551e9c05fa889a43aa6ec854c942535723 Mon Sep 17 00:00:00 2001 From: Nell Shamrell Date: Tue, 11 Dec 2018 15:17:47 -0800 Subject: [PATCH 1/2] Adds definitions for projects and maintainership of projects --- definitions.md | 15 +++++++++++++++ maintainership.md | 15 +++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 definitions.md create mode 100644 maintainership.md diff --git a/definitions.md b/definitions.md new file mode 100644 index 0000000..3eea8fb --- /dev/null +++ b/definitions.md @@ -0,0 +1,15 @@ +# Definitions + +## Project + +### Product + +A Product consists of one or more Projects. + +### Project + +A Project is one GitHub repo that contains code. + +### Maintainers + +A Project has many maintainers. \ No newline at end of file diff --git a/maintainership.md b/maintainership.md new file mode 100644 index 0000000..49c2ba9 --- /dev/null +++ b/maintainership.md @@ -0,0 +1,15 @@ +# Maintainership of Projects + +## Definition +* Projects have **maintainers**, not authors +* The maintainers are responsible for merging pull requests, triaging issues, and more. + +## Rules and Responsibilities +* At least two maintainers must be current Chef employees +* Roadmaps are planned by Product Management, Engineering Leadership, and maintainers (including external maintainers - who have input, but not veto power) +* Maintainers are responsible for **communicating** overall project planning and roadmap of their project. +* Maintainer reviews are required on all code and maintainers are the only ones that can merge code into a project. If you need to merge code, then you are a maintainer. +* All maintainer team discussion outside of security issues should be done in a public forum. +* The maintainer team is added as a codeowner on their repository so that they are automatically setup via Github for code reviews +* All contributions must include Developer Certificate of Origin signoff +* A tool is setup to ping maintainers for reviews / triage. From f73e95a1521d878768ad23dea77ff87e31227161 Mon Sep 17 00:00:00 2001 From: Nell Shamrell Date: Wed, 12 Dec 2018 13:01:31 -0800 Subject: [PATCH 2/2] clarifies definitions of projects and maintainers Signed-off-by: Nell Shamrell --- definitions.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/definitions.md b/definitions.md index 3eea8fb..8c6b7c1 100644 --- a/definitions.md +++ b/definitions.md @@ -1,15 +1,15 @@ # Definitions -## Project +### Project + +A Project is one GitHub repo that contains code. ### Product A Product consists of one or more Projects. -### Project - -A Project is one GitHub repo that contains code. +### Maintainer -### Maintainers +A maintainer is responsible for merging pull requests, triaging issues, and general project maintenance. A Project has many maintainers. \ No newline at end of file