Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

504 when fetching comment #32

Closed
devnoname120 opened this issue Apr 7, 2019 · 3 comments
Closed

504 when fetching comment #32

devnoname120 opened this issue Apr 7, 2019 · 3 comments

Comments

@devnoname120
Copy link

Tests:

Proof that this id is valid: https://news.ycombinator.com/item?id=3338903

Might be related to this: #18 (comment)

@cheeaun
Copy link
Owner

cheeaun commented Apr 9, 2019

Oh, hmm. First, this API doesn't work for comment-type IDs. Or at least I didn't test and not planning to support it. For HN's official API, the ID is an Item ID, which can be a story or comment type.

So the ID is valid, just that node-hnapi is not supporting comment-type ID.

@devnoname120
Copy link
Author

Ah thanks, in this case I'm updating the documentation because it's incorrect: https://github.com/cheeaun/node-hnapi/wiki/API-Documentation#get-itemid

@cheeaun
Copy link
Owner

cheeaun commented Apr 9, 2019

@devnoname120 thanks! sorry for the confusion 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants