Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FramesLanguages type does not list all supported languages #55

Closed
darkensk opened this issue May 14, 2024 · 1 comment
Closed

FramesLanguages type does not list all supported languages #55

darkensk opened this issue May 14, 2024 · 1 comment

Comments

@darkensk
Copy link

darkensk commented May 14, 2024

In types : checkout/frames-react/src/frames/types/types.tsx the FramesLanguages type states the languages are

export type FramesLanguages = 'EN-GB' | 'ES-ES' | 'FR-FR' | 'DE-DE' | 'KR-KR' | 'IT-IT' | 'NL-NL';

but according to the Get started with Frames

the available languages that one can use are

Arabic = AR
Chinese Simplified = ZH-CH
Chinese Traditional (Hong Kong) = ZH-HK
Chinese Traditional (Taiwan) = ZH-TW
Danish = DA-DK
Dutch = NL-NL
English = EN-GB
Filipino = FIL-PH
Finnish - FI-FI
French = FR-FR
German = DE-DE
Hindi = HI-IN
Indonesian = ID-ID
Italian = IT-IT
Japanese = JA-JP
Korean = KO-KR
Malay = MS-MY
Norwegian Bokmål = NB-NO
Spanish = ES-ES
Swedish = SV-SE
Thai = TH-TH
Vietnamese = VI-VN

I've tried passing in the SV-SE for example and got the correct localization in the frames fields, so I think only change needed is to extend the type.

@darkensk
Copy link
Author

This has been fixed in #58 and release in version 1.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant