Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception is raised in parse_response if status code is 3xx #155

Open
1 task done
andriuszazeckas opened this issue Dec 13, 2024 · 0 comments
Open
1 task done

Exception is raised in parse_response if status code is 3xx #155

andriuszazeckas opened this issue Dec 13, 2024 · 0 comments

Comments

@andriuszazeckas
Copy link

andriuszazeckas commented Dec 13, 2024

Environment

  • Checkout SDK version: 1.2.3

Description

https://github.com/checkout/checkout-sdk-ruby/blob/master/lib/checkout_sdk/api_client.rb
Line 112 raises exception on 302 response which is a succesfull response - https://api-reference.checkout.com/#operation/getReportFile

Expected behavior

It is expected to raise exception on 4xx status

Possible solution

Change line 112 to:
raise CheckoutApiException, response if response.status < 200 || response.status >= 400

  • I may be able to implement this bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant