Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release notes for 1.29+ck2 and now 1.29+ck3 #843

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Prepare release notes for 1.29+ck2 and now 1.29+ck3 #843

merged 11 commits into from
Jun 25, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented May 30, 2024 •
edited
Loading

Preparing release-note for charmed-kubernetes 1.29+ck2

Roughly based on the bugs fixed in the milestone

The adjustment to the release-node generator templates reflects the current release-notes pages.

@netlify Netlify
Copy link

netlify bot commented May 30, 2024 •
edited
Loading

✅ Deploy Preview for cdk-next ready!

Name Link
🔨 Latest commit 6611202
🔍 Latest deploy log https://app.netlify.com/sites/cdk-next/deploys/667af143948c30000816b1a4
😎 Deploy Preview https://deploy-preview-843--cdk-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

addyess
addyess commented May 30, 2024
View reviewed changes
pages/k8s/how-to-cos-lite.md
Relate `grafana-agent` to `k8s`, `kubernetes-control-plane` and `kubernetes-worker`:
Relate `grafana-agent` to charmed kubernetes applications:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaces k8s with kubeapi-load-balancer as i'm sure the original author mistakenly wrote here.

evilnick
evilnick reviewed Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@evilnick evilnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - i couldn't make sense of where to add a line to the template to fix this forever...

@kwmonroe kwmonroe marked this pull request as draft June 7, 2024 14:20
@kwmonroe
Copy link
Contributor

kwmonroe commented Jun 7, 2024

Setting to draft to make sure we include keystone / vault / ceph upgrade notes.

@addyess
Copy link
Member Author

addyess commented Jun 7, 2024

I feel bad i didn't make it clear this was THE change to for the 1.29+ck2 release. Nice to have a chat with you both so we know what is necessary to close out last weeks' release

@addyess @evilnick
Beginning notes on how to reconfigure for keystone in 1.29 (#845)
c488cf7 
* Correct command mistakes in keystone upgrade nodes, add Day2 Ops section
* Add installation instructions to use LDAP or Keystone Auth for fresh installations
* Applied review comments from Nick

---------

Co-authored-by: Nick Veitch <[email protected]>
@addyess addyess changed the title Prepare release notes for 1.29+ck2, update generator templates Prepare release notes for 1.29+ck2 and now 1.29+ck3 Jun 14, 2024
@evilnick
Copy link
Collaborator

I'm not done with this but just making some running tweaks. How close are we to having all the bits?

@kwmonroe kwmonroe marked this pull request as ready for review June 21, 2024 05:37
@kwmonroe
Copy link
Contributor

kwmonroe commented Jun 21, 2024 •
edited
Loading

I'm not done with this but just making some running tweaks. How close are we to having all the bits?

@evilnick i think we're good2go here. I did notice the release-notes-headers.j2 template removed some quotes and modified the yaml structure, but the 1.29/release-notes.md puts them back. I'm not sure which way is supposed to be the source of truth there, but I trust you'll know what to do if an update is needed to either :)

@addyess addyess mentioned this pull request Jun 21, 2024
Merged
@evilnick
Copy link
Collaborator

I'm calling this done for now, I may pick up some other things.
I don't really like how complicated this is and that we require people to look at a load of notes, but I don't see a clean way to do it. Thanks for all your work on this.

@evilnick evilnick merged commit 90106db into main Jun 25, 2024
11 checks passed
@evilnick evilnick deleted the akd/prepare-release-notes-/1.29-ck2 branch June 25, 2024 16:59
@evilnick evilnick mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilnick evilnick evilnick left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addyess @kwmonroe @evilnick